-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for Mainframe.cpp, CalibrationPressureAdvDialog.cpp, some other corrections, additions #4364
base: nightly_dev
Are you sure you want to change the base?
Conversation
can you please create this PR for my repo/branch? thanks. |
I would have to clone your repo first or need write access to your repo. You can merge the code much easier this way: git remote add caribou3d [email protected]:Caribou3d/SuperSlicer.git and finally remove remote git remote remove caribou3d |
std::string nozzle_diameter_str = std::to_string(nozzle_diameter); | ||
std::replace(nozzle_diameter_str.begin(), nozzle_diameter_str.end(), ',', '.'); | ||
nozzle_diameter_str.erase(nozzle_diameter_str.find_last_not_of('0') + 2, std::string::npos); | ||
std::cout << "Nozzle: " << nozzle_diameter_str << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you forget to remove the console debugging ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep :)
figured it would be easier on others to keep changes in my repo as merils repo can be outofdate with changes i make. the localization bug originates with |
`
` I'm not sure why this happens here. I noticesd that the conversion of the nozzle diameter causes a problem when loading the files |
if it only crashes/breaks because not being able to load the model it'll be better to just adjust it like
is it only crashing on loading a model or elsewhere? |
The conversion of other vakues fails as well ` double first_pa = wxAtof(firstPaValue);
` pa_increment is zero and the dimension of the array is infinity. There is another section of the code with that error. |
it'll be failing there because the comobox box contains a string of numbers and the OS/something else see's it as a string of text and changes it.
this would be failing because of above main issue. but i guess i could add a safe guard check before it starts the while loop to confirm if the variables have i'll need to look more into wxwidgets to see how to create a combobox for double/floats instead of strings. |
some modification to enable translation of the lables, initial German trnaslation of the html page |
5e0f604
to
787415d
Compare
787415d
to
5dc2ae8
Compare
97361d8
to
2aea702
Compare
Some fixes:
CalibrationPressureAdvDialog.cpp: The conversions from string to double depend on locale / language ( , vs. . as delimiter) . Switching to German will cause a crash. This is fixed here.
Mainframe.cpp: fixes setting of braces and #endif
.gitignore: adds cmake/CPackConfig.cmake
filament_pressure.html: some typos corrected
BuildLinux.sh: remove --all from export NCORES=
nproc --all
. When --all is activated too many processes are generated on a virtual machine